Developper feature improvement: Include the form key in the form() method of qa_theme_base

Question

This would allow us to modify some elements in particular forms by overidding the form() method and checking the name. I've done it for my site this way:

In function main_parts($content), I've simply changed this

elseif (strpos($key, 'form')===0)
                    $this->form($part);

to

elseif (strpos($key, 'form')===0) {
                    $this->form($part,$key);

And added the key parameter to form($form) which became form($form,$formkey=null).

Since this method is called at some place, the null ensures compatibilty with other versions.
       

Answer 1

I can see the value of this, but the problem is that the key in most cases is just 'form', so a safer way to identify the form type might be to look at the template in $this->template. 

Comments

Template is in fact useful. A page where the form key is useful, is on the page_question since it contains many forms. Thanks!