Private Messages link present when using external users

Question

Version: 1.7.0

We are using external users and when visiting my account page, I have a link to my private messages. This should be disabled when using external users.

To fix this, I added the following line to my custom theme:

unset($this->content['navigation']['sub']['messages']);

I've also modified pages/message.php and pages/messages.php so users don't get a crash dump if they get to those pages:

    if (QA_FINAL_EXTERNAL_USERS)
        qa_fatal_error('User accounts are handled by external code');

to:

    if (QA_FINAL_EXTERNAL_USERS)
        return include QA_INCLUDE_DIR.'qa-page-not-found.php';

Not sure if there are other things to modify, but I'm just giving a head's up in case someone got into that problem.

Answer 1

I fixed this by editing line 1343 of format.php to:

if (QA_FINAL_EXTERNAL_USERS || !$ismyuser || !qa_opt('allow_private_messages') || !qa_opt('show_message_history'))
            unset($navigation['messages']);